This repository was archived by the owner on Sep 20, 2021. It is now read-only.
Support a user defined name for the schema_migrations table #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Useful e.g. where you have a DB build with multiple migration tools that both want to write to schema_migrations |
|
@ameingast is this something you would accept? I'd also like to have similar functionality (in my case, to force the |
|
Yup, as long as full backwards compatibility is guaranteed, this will be merged in, once I have some time on my hands. |
|
@andrevdm will you be rebasing this change on current master? If not, I can take a stab at doing this. |
|
Hi,
Good point, sure I'll do that this afternoon. As far as I can see it is
backwards compatible, I've not had any issues so far
…On Wed, 1 Jul 2020 at 17:48, Arun Raghavan ***@***.***> wrote:
@andrevdm <https://github.com/andrevdm> will you be rebasing this change
on current master? If not, I can take a stab at doing this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAASDKSOXQVZZXY3WTUGYJDRZNLDHANCNFSM4JABGFPQ>
.
|
Added runMigration' and runMigrations'. These two function support an extra parameter over the non-prime ones. This param is the name of the scschema_migrations table that the user has selected. Adding two new functions like this means there are no breaking changes for existing users.
Not very pretty...
|
rebased on master and pushed. I'll do a few more tests now |
|
There is a bit of duplication in the code, e.g. MigrationContext' vs MigrationContext but think its justified for backwards comparability. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added runMigration' and runMigrations'. These two function support an extra parameter over the non-prime ones. This param is the name of the scschema_migrations table that the user has selected.
Adding two new functions like this means there are no breaking changes for existing users.